Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cache_dir config option to ForkConfig - feat/multichain #749

Open
wants to merge 4 commits into
base: feat/multichain
Choose a base branch
from
Open

Move cache_dir config option to ForkConfig - feat/multichain #749

wants to merge 4 commits into from

Conversation

iosh
Copy link

@iosh iosh commented Dec 15, 2024

resolve #740

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a9d081d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iosh iosh force-pushed the 740 branch 3 times, most recently from 3a1dfff to f48a18e Compare December 15, 2024 12:12
@iosh
Copy link
Author

iosh commented Dec 16, 2024

Please review this PR first. If everything is fine, I will update the other one.

Wodann
Wodann requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Almost there!

One more request and then I'll validate CI

crates/edr_napi/Cargo.toml Outdated Show resolved Hide resolved
@iosh iosh requested a review from Wodann December 17, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wodann Wodann Awaiting requested review from Wodann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iosh @Wodann