Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into feat/multichain #765

Merged
merged 32 commits into from
Jan 7, 2025
Merged

Merge main into feat/multichain #765

merged 32 commits into from
Jan 7, 2025

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Jan 6, 2025

This PR merges main into feat/multichain. Once ready, it should be pushed to feat/multichain manually to ensure the merge commit is registered.

agostbiro and others added 30 commits January 2, 2025 11:26
* wip: make tracing config a provider argument

* Patch Hardhat to pass tracing config to provider

---------

Co-authored-by: Franco Victorio <victorio.franco@gmail.com>
This function has to match the latest tested solc version in the stack traces tests.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 3415702

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Jan 6, 2025
@Wodann Wodann self-assigned this Jan 6, 2025
@Wodann Wodann had a problem deploying to github-action-benchmark January 6, 2025 22:11 — with GitHub Actions Error
@Wodann Wodann linked an issue Jan 6, 2025 that may be closed by this pull request
@Wodann Wodann temporarily deployed to github-action-benchmark January 6, 2025 22:22 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark January 6, 2025 22:42 — with GitHub Actions Inactive
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 3.50117% with 2894 lines in your changes missing coverage. Please review.

Project coverage is 54.17%. Comparing base (7f21538) to head (3415702).
Report is 32 commits behind head on feat/multichain.

Files with missing lines Patch % Lines
crates/edr_solidity/src/error_inferrer.rs 1.85% 1584 Missing ⚠️
crates/edr_solidity/src/nested_tracer.rs 0.00% 262 Missing ⚠️
crates/edr_solidity/src/solidity_tracer.rs 0.00% 193 Missing ⚠️
crates/edr_napi/src/trace/solidity_stack_trace.rs 0.00% 185 Missing ⚠️
crates/edr_solidity/src/contract_decoder.rs 0.00% 152 Missing ⚠️
...src/mapped_inline_internal_functions_heuristics.rs 0.00% 112 Missing ⚠️
crates/edr_solidity/src/compiler.rs 0.00% 51 Missing ⚠️
crates/edr_solidity/src/nested_trace.rs 0.00% 48 Missing ⚠️
...ates/edr_provider/src/requests/hardhat/compiler.rs 0.00% 39 Missing ⚠️
crates/edr_napi_core/src/spec.rs 0.00% 34 Missing ⚠️
... and 24 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/multichain     #765      +/-   ##
===================================================
+ Coverage            53.98%   54.17%   +0.19%     
===================================================
  Files                  243      243              
  Lines                28142    28080      -62     
  Branches             28142    28080      -62     
===================================================
+ Hits                 15192    15212      +20     
+ Misses               12060    11978      -82     
  Partials               890      890              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wodann Wodann temporarily deployed to github-action-benchmark January 7, 2025 03:47 — with GitHub Actions Inactive
@Wodann Wodann merged commit 3415702 into feat/multichain Jan 7, 2025
40 of 41 checks passed
@Wodann Wodann deleted the merge/main branch January 7, 2025 04:40
@Wodann Wodann temporarily deployed to github-action-benchmark January 7, 2025 04:40 — with GitHub Actions Inactive
@Wodann Wodann changed the title [DON'T MERGE] Merge main into feat/multichain Merge main into feat/multichain Jan 7, 2025
@Wodann Wodann requested a review from a team January 7, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate stack traces refactor in feat/multichain
3 participants