Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network id convert to hex must be number #100 #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Network id convert to hex must be number #100 #101

wants to merge 1 commit into from

Conversation

liangxiwei
Copy link

@liangxiwei liangxiwei commented Dec 6, 2023 •
edited
Loading

lukaw3d
lukaw3d reviewed Nov 18, 2024
View reviewed changes
frontend/src/components/Dapp.js
@@ -20,7 +20,7 @@ import { WaitingForTransactionMessage } from "./WaitingForTransactionMessage";
import { NoTokensMessage } from "./NoTokensMessage";

// This is the default id used by the Hardhat Network
const HARDHAT_NETWORK_ID = '31337';
const HARDHAT_NETWORK_ID = 31337;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes

hardhat-boilerplate/frontend/src/components/Dapp.js

Line 348 in d441aed

const chainIdHex = `0x${HARDHAT_NETWORK_ID.toString(16)}`

but breaks

hardhat-boilerplate/frontend/src/components/Dapp.js

Line 358 in d441aed

if (window.ethereum.networkVersion !== HARDHAT_NETWORK_ID) {

@lukaw3d lukaw3d mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangxiwei @lukaw3d