Skip to content

Commit

Permalink
fix existing library bug and add comment for known issue
Browse files Browse the repository at this point in the history
  • Loading branch information
zoeyTM committed Nov 20, 2024
1 parent a62df74 commit 2d17233
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ const VisualizeDiv = styled.div`
width: 100%;
`;

// TODO: when we added the future-to-module dependency, we created a non-ideal situation where
// a module-to-module dependency arrow still gets added to the mermaid graph, even if the dependant module
// is only used as a future-to-module dependency. This is because the dependant module has to get added to the
// parent module as a submodule, and we currently don't have a way of distinguishing at this point in the code between
// a submodule that is exclusively used as a future-to-module dependency (i.e. in { after: [...] })
// and a submodule that is used as a module-to-module dependency (i.e. in m.useModule(...)).
// This is a known issue that we have decided to revisit at a later point in time because the solution is not trivial.
const FlowTooltip: React.FC = () => (
<span style={{ paddingLeft: "0.5rem", cursor: "pointer" }}>
<a data-tooltip-id="flow-tooltip">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ export const FutureHeader: React.FC<{
setCurrentlyHovered: (id: string) => void;
future: Future;
}> = ({ isLibrary, toggled, displayText, setCurrentlyHovered, future }) => {
if (isLibrary) {
return (
<ToggleNameWrap>
<div />
<Text>{displayText}</Text>
</ToggleNameWrap>
);
}

return (
<ToggleNameWrap>
{isLibrary ? <div /> : <ToggleBtn toggled={toggled} />}
Expand Down

0 comments on commit 2d17233

Please sign in to comment.