Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve no deployment error message in status #527

Closed
kanej opened this issue Oct 9, 2023 · 1 comment · Fixed by #537 or #541
Closed

Improve no deployment error message in status #527

kanej opened this issue Oct 9, 2023 · 1 comment · Fixed by #537 or #541
Assignees
@zoeyTM
Labels
status:ready This issue is ready to be worked on
Milestone
Beta v0.11.0

Comments

@kanej
Copy link
Member

kanej commented Oct 9, 2023

If you run the status command with a non-existant deployment id you get:

image

At the least the stack trace should be removed. Maybe a pattern to follow is HHs:

image
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Oct 9, 2023
@kanej kanej moved this to Todo in Hardhat Ignition Oct 9, 2023
@kanej kanej added this to the Beta v0.5.0 milestone Oct 9, 2023
@kanej kanej mentioned this issue Oct 10, 2023
Closed
20 tasks
@alcuadrado
Copy link
Member

Let's rethrow with a message that includes the ignition error code. The errors thrown should be NomicFoundationHardhatPluginError. This won't show any Hardhat error code, but it works for now. Then we will extend Hardhat so that the error-code system is extensible.

@zoeyTM zoeyTM self-assigned this Oct 10, 2023
@zoeyTM zoeyTM moved this from Todo to In Progress in Hardhat Ignition Oct 10, 2023
kanej added a commit that referenced this issue Oct 10, 2023
@kanej
remove support for module file names in tasks
858994f 
We are removing support for invoking a module just by giving its file
name. Instead the tasks will work in terms of a full or relative path to
the module file.

Users prefer this for autocomplete reasons anyway, but it removes
confusion as to whether it is the `ModuleId` or filename that is in use
here.

Resolves #527.
kanej added a commit that referenced this issue Oct 10, 2023
@kanej
remove support for module file names in tasks
2f73e98 
We are removing support for invoking a module just by giving its file
name. Instead the tasks will work in terms of a full or relative path to
the module file.

Users prefer this for autocomplete reasons anyway, but it removes
confusion as to whether it is the `ModuleId` or filename that is in use
here.

Resolves #527.
kanej added a commit that referenced this issue Oct 10, 2023
@kanej
remove support for module file names in tasks
843538f 
We are removing support for invoking a module just by giving its file
name. Instead the tasks will work in terms of a full or relative path to
the module file.

Users prefer this for autocomplete reasons anyway, but it removes
confusion as to whether it is the `ModuleId` or filename that is in use
here.

Resolves #527.
@kanej kanej mentioned this issue Oct 10, 2023
Merged
kanej added a commit that referenced this issue Oct 10, 2023
@kanej
remove support for module file names in tasks
44810d8 
We are removing support for invoking a module just by giving its file
name. Instead the tasks will work in terms of a full or relative path to
the module file.

Users prefer this for autocomplete reasons anyway, but it removes
confusion as to whether it is the `ModuleId` or filename that is in use
here.

Resolves #527.
@zoeyTM zoeyTM moved this from In Progress to In Review in Hardhat Ignition Oct 10, 2023
@zoeyTM zoeyTM mentioned this issue Oct 10, 2023
Merged
kanej pushed a commit that referenced this issue Oct 11, 2023
@zoeyTM
handle error thrown by status task (#541)
6088ac5 
Use a whitelist to determine whether a code `IgnitionError` should be rethrown as a Hardhat plugin error. This list can be added to as more Ignition errors are identified as being better displayed as HH errors.

We intend to extend the HH error code mechanism to give Ignition even more control over the display of errors in HH.

This change only adds this rethrow for status and the unrecognised deployment entry currently.

Fixes #527.
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Ignition Oct 11, 2023
kanej added a commit that referenced this issue Oct 12, 2023
@kanej
remove support for module file names in tasks
2ea32d5 
We are removing support for invoking a module just by giving its file
name. Instead the tasks will work in terms of a full or relative path to
the module file.

Users prefer this for autocomplete reasons anyway, but it removes
confusion as to whether it is the `ModuleId` or filename that is in use
here.

Resolves #527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoeyTM zoeyTM

Labels
status:ready This issue is ready to be worked on
Projects
Hardhat Ignition
Archived in project
Milestone
Beta v0.11.0
3 participants
@kanej @alcuadrado @zoeyTM