Final figma updates to visualize UI (PR 3) #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
changed the title
kanej
changed the title
Take the laptop width of 1280px as a minimum, set the main content width as 920px (with padding 180px). This means the mermaid diagram will always have a minimum width - leading to a better outcome. I also cleaned up some console errors due to react + the svg.
To fix the toggle movement on the +/- toggle. I have wrapped the button header so that a set width can be set on the toggle button the following text. The right aligned module name has to be brought in again.
Switch back to text-align left for the future header text. Limit the centering of text to only the +/- button.
We have switched to `.` to represent the separator before the call.
We use the Argument components both in lists and as standalone values (`to` in send data for example). The previous Argument component included a li which doesn't work as well for the standalone values. The `li` is now added at the list level, while the Argument component returns either a `p` or `a` depending on the type of argument being displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.