Add link to transactions list command output #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoeyTM
force-pushed
the
link-in-transactions
branch
2 times, most recently
from
b3577ea to
e039e4e
Compare
alcuadrado
reviewed
Dec 17, 2024
| @@ -76,6 +77,10 @@ export async function listTransactions( | |||
| (tx) => tx.hash === message.transaction.hash | |||
| ); | |||
|
|
|||
| const browserUrl = builtinChains.find( | |||
There was a problem hiding this comment.
I think this can be done before the for in line 54, so that we only run it once.
alcuadrado
approved these changes
Dec 17, 2024
zoeyTM
force-pushed
the
link-in-transactions
branch
from
e039e4e to
5223b5b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #838