Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge fmt not picking up settings from foundry.toml #410

Closed
antico5 opened this issue Feb 28, 2023 · 0 comments · Fixed by #422
Closed

forge fmt not picking up settings from foundry.toml #410

antico5 opened this issue Feb 28, 2023 · 0 comments · Fixed by #422
Labels
status:ready This issue is ready to be worked on
Milestone
Standalone langua...

Comments

@antico5
Copy link
Collaborator

antico5 commented Feb 28, 2023

As reported by bassquake on discord:

I'm having some problems with the formatter when set to "forge". I would expect this to read in the foundry.toml settings to pick up things like Line Length, but it seems like it still doesn't follow that rule.

Additionally they mention that it's a monorepo setup.
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Mar 6, 2023
@kanej kanej moved this to Todo in hardhat-vscode Mar 6, 2023
@kanej kanej added status:ready This issue is ready to be worked on and removed status:ready This issue is ready to be worked on labels Mar 6, 2023
@kanej kanej added this to the Standalone language server milestone Mar 7, 2023
@antico5 antico5 moved this from Todo to In Progress in hardhat-vscode Mar 8, 2023
@antico5 antico5 moved this from In Progress to In Review in hardhat-vscode Mar 8, 2023
@antico5 antico5 mentioned this issue Mar 8, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done in hardhat-vscode Mar 10, 2023
@antico5 antico5 mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
hardhat-vscode
Status: Done
Milestone
Standalone language server
Development

Successfully merging a pull request may close this issue.

fix: forge fmt on monorepos NomicFoundation/hardhat-vscode
2 participants
@kanej @antico5