Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forge fmt on monorepos #422

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix: forge fmt on monorepos #422

merged 1 commit into from
Mar 10, 2023

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Mar 8, 2023

Closes #410

@antico5 antico5 requested a review from kanej March 8, 2023 14:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (development@3ad56e7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3ad77a0 differs from pull request most recent head 59be255. Consider uploading reports for the commit 59be255 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff               @@
##             development     #422   +/-   ##
==============================================
  Coverage               ?   55.67%           
==============================================
  Files                  ?      175           
  Lines                  ?     4469           
  Branches               ?      737           
==============================================
  Hits                   ?     2488           
  Misses                 ?     1749           
  Partials               ?      232           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is going on here, probable needs rebased, but the forge commit is good for merge!

@antico5 antico5 force-pushed the forge_fmt_settings branch from f12da2f to 59be255 Compare March 9, 2023 17:13
@antico5 antico5 merged commit fe162f5 into development Mar 10, 2023
@antico5 antico5 deleted the forge_fmt_settings branch March 10, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

forge fmt not picking up settings from foundry.toml
3 participants