Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quickfix for data location #281

Merged

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Nov 17, 2022

This feature adds a quickfix for solidity errors involving data location (add/change/remove).

@linear
Copy link

linear bot commented Nov 17, 2022

HHVSC-238 Quickfix for data location not specified (6651).

It would be nice to have a quickfix for memory, storage and calldata specifiers.

@antico5 antico5 requested a review from kanej November 18, 2022 13:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (development@d0da168). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0e26802 differs from pull request most recent head b88a3fe. Consider uploading reports for the commit b88a3fe to get more accurate results

@@              Coverage Diff               @@
##             development     #281   +/-   ##
==============================================
  Coverage               ?   57.35%           
==============================================
  Files                  ?      174           
  Lines                  ?     4294           
  Branches               ?      700           
==============================================
  Hits                   ?     2463           
  Misses                 ?     1601           
  Partials               ?      230           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@antico5 antico5 force-pushed the quickfix-for-data-location-not-specified-hhvsc-238 branch 2 times, most recently from b88a3fe to 5733e35 Compare November 18, 2022 15:19
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested on windows.

Lets hold off on merging until we have the agnostic refactor cleared from dev.

@antico5 antico5 force-pushed the quickfix-for-data-location-not-specified-hhvsc-238 branch 2 times, most recently from 3ff5daf to 4e39467 Compare November 21, 2022 13:35
@antico5 antico5 force-pushed the quickfix-for-data-location-not-specified-hhvsc-238 branch from 4e39467 to 406f1d7 Compare November 24, 2022 11:59
@antico5 antico5 merged commit a394676 into development Nov 24, 2022
@antico5 antico5 deleted the quickfix-for-data-location-not-specified-hhvsc-238 branch November 24, 2022 12:00
@kanej kanej mentioned this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants