Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set worker exit code to info and check worker status on watchedFilesChanged #298

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Nov 28, 2022

Worker exit code is not logged on an error line anymore. Additionally, worker status is checked when responding to onWatchedFilesChanged to avoid sending InvalidateCacheMessage to a dead worker.

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think we need to consider how to bring the rules in this file under test so we can document with regression tests the choices we are making.

@antico5 antico5 merged commit 2ee7de5 into development Nov 29, 2022
@antico5 antico5 deleted the fix-noise-sentry-errors branch November 29, 2022 11:59
@kanej kanej mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants