fix: forge fmt respects project's foundry.toml #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: move server indexing and analysis to `initialize` step * wip * split index into different files * mocha setup * add tests and methods for diagnostics * hardhat test project on protocol tests * reword "integration" to "e2e" * add references test * textDocument/implementation test * add diagnostics test for foundry and projectless * textDocument/definition test * textDocument/typeDefinition test * textDocument/rename tests * migrate codeAction tests * exclude protocol tests from root build * migrate completion tests * remove makeCodeAction helper * definition tests * migrate all diagnostic tests * migrate all textDocument/references tests * migrate remapping integration tests * migrate rename tests * migrate all typeDefinition tests * update all test projects to use solc 0.8.8 * remove linear-related workflows * add build step to CI * increase timeout on waiting for diagnostic because of compiler download * add protocol tests' node_modules to cache * fix indexing workspace folders on windows * use file uris for locations instead of paths * install packages on protocol tests' projects * add linting to protocol tests * send custom/analyzed notification only on test mode
Codecov Report
@@ Coverage Diff @@
## development #316 +/- ##
==============================================
Coverage ? 57.13%
==============================================
Files ? 173
Lines ? 4316
Branches ? 707
==============================================
Hits ? 2466
Misses ? 1618
Partials ? 232 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks @mds1, that is great. We will get it reviewed in the next few days. |
kanej
reviewed
Dec 20, 2022
|
Huh looks like some CI tests failed for |
|
@mds1 don't worry about that, macOS CI sometimes fails to download and install foundry and then some tests fail. This change is not breaking any tests |
kanej
approved these changes
Dec 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to juanfranblanco/vscode-solidity#363 (h/t @shekhirin), this PR ensures the formatter respects the
fmtsettings in thefoundry.tomlfile