Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remappings structure as solc input #377

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Jan 19, 2023

We are sending the remappings object to solc with absolute paths, e.g:

    "remappings": [
      "ds-test/=/home/.../projects/.../lib/forge-std/lib/ds-test/src/",
      "forge-std/=/home/.../projects/.../lib/forge-std/src/",
    ]

After this change, the remappings object is sent in the way they are declared, without transforming relative into absolute paths, e.g:

    "remappings": [
      "ds-test/=lib/forge-std/lib/ds-test/src/",
      "forge-std/=lib/forge-std/src/",
    ]

Closes #369

@antico5 antico5 force-pushed the fix_remappings_config_sent_to_solc branch from 1c9955c to c33429f Compare February 7, 2023 16:40
@antico5
Copy link
Collaborator Author

antico5 commented Feb 14, 2023

@kanej just checked and this one is good to go

@antico5 antico5 merged commit 746cd96 into development Feb 14, 2023
@antico5 antico5 deleted the fix_remappings_config_sent_to_solc branch February 14, 2023 14:57
This was referenced Feb 17, 2023
kanej pushed a commit that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Does not work with the "src/=src/" remappings
2 participants