Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce server dependencies #382

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Jan 24, 2023

This moves all dependencies (except solidity-analyzer) to devDependencies on the server package. This drastically reduces the installation time of the coc extension and the size from ~180mb to ~20mb.

Closes #373

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Merging #382 (678c287) into development (965a25a) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #382   +/-   ##
============================================
  Coverage        55.83%   55.83%           
============================================
  Files              176      176           
  Lines             4461     4461           
  Branches           738      738           
============================================
  Hits              2491     2491           
  Misses            1735     1735           
  Partials           235      235           
Impacted Files Coverage Δ
src/utils/index.ts 80.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antico5 antico5 force-pushed the reduce_server_deps_for_coc branch from 678c287 to c7db228 Compare February 7, 2023 16:39
@antico5 antico5 merged commit 24aaaa0 into development Feb 7, 2023
@antico5 antico5 deleted the reduce_server_deps_for_coc branch February 7, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reduce coc-solidity deps
3 participants