Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support node 14 #471

Merged
merged 1 commit into from
Apr 28, 2023
Merged

chore: support node 14 #471

merged 1 commit into from
Apr 28, 2023

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Apr 27, 2023

Changed the target on esbuild to node14. By default it is esnext.

Manually ran protocol tests on node 14 and they are passing

Resolves #461

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #471 (92a3a98) into development (ada125e) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 92a3a98 differs from pull request most recent head aa0a9df. Consider uploading reports for the commit aa0a9df to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@               Coverage Diff               @@
##           development     #471      +/-   ##
===============================================
- Coverage        53.65%   53.46%   -0.19%     
===============================================
  Files              187      187              
  Lines             4799     4799              
  Branches           790      790              
===============================================
- Hits              2575     2566       -9     
- Misses            1991     1997       +6     
- Partials           233      236       +3     

see 3 files with indirect coverage changes

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antico5 antico5 merged commit 9072c66 into development Apr 28, 2023
@antico5 antico5 deleted the node_14_support branch April 28, 2023 15:28
@kanej kanej linked an issue May 3, 2023 that may be closed by this pull request
kanej pushed a commit that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Language server issue on node 14
3 participants