chore: stop capturing initialize errors #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## development #474 +/- ##
===============================================
- Coverage 53.65% 53.35% -0.31%
===============================================
Files 187 187
Lines 4799 4811 +12
Branches 790 790
===============================================
- Hits 2575 2567 -8
- Misses 1991 2008 +17
- Partials 233 236 +3 |
kanej
requested changes
May 1, 2023
Apply the same appraoch across truffle/ape/foundry and only log in initialize rather than sending to sentry.
kanej
pushed a commit
that referenced
this pull request
May 3, 2023
Instead of passing Ape/Truffle/Foundry initialization errors to sentry, we log for the user only. We don't rethrow truffle project errors, matching the pattern used in other adapters. Resolves #473.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the new errors appearing on sentry related to project initialization. I just realized that our logger creates error entries when we call the
.errormethod. I replaced existing logging related to project initialization fromerrorcalls toinfo, to avoid this.