Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return ok when no diagnostics passed to onCodeAction #494

Merged
merged 1 commit into from
May 23, 2023

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented May 18, 2023

Closes #488

@codecov-commenter
Copy link

Codecov Report

Merging #494 (9f65680) into development (9cfb24b) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 9f65680 differs from pull request most recent head 522e9fe. Consider uploading reports for the commit 522e9fe to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           development     #494      +/-   ##
===============================================
- Coverage        53.52%   53.33%   -0.19%     
===============================================
  Files              187      187              
  Lines             4813     4813              
  Branches           791      791              
===============================================
- Hits              2576     2567       -9     
- Misses            2003     2009       +6     
- Partials           234      237       +3     

see 3 files with indirect coverage changes

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antico5 antico5 force-pushed the codeaction_telemetry branch from 522e9fe to 04bab7d Compare May 22, 2023 15:31
@antico5 antico5 merged commit 10b1928 into development May 23, 2023
@antico5 antico5 deleted the codeaction_telemetry branch May 23, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change onCodeAction telemetry reporting so zero diagnostics is success
3 participants