Check that errors come from reverted txs

packages/hardhat-chai-matchers/src/reverted.ts

@@ -63,6 +63,10 @@ export function supportReverted(Assertion: Chai.AssertionStatic) {
         throw new AssertionError("Expected an Error object");
       }
 
+      if (!isRevertError(error)) {
+        return Promise.reject(error);
+      }
+
       this.assert(true, null, "Expected transaction NOT to be reverted");
     };
 
@@ -303,6 +307,15 @@ export function supportReverted(Assertion: Chai.AssertionStatic) {
   });
 }
 
+function isRevertError(error: any): boolean {
+  try {
+    getReturnDataFromError(error);
+    return true;
+  } catch (e) {
+    return false;
+  }
+}
+
 function getReturnDataFromError(error: any): string {
   const errorData = (error as any).data;
 

packages/hardhat-chai-matchers/test/reverted.ts

@@ -291,6 +291,28 @@ describe("INTEGRATION: Reverted", function () {
           "Expected an Error object"
         );
       });
+
+      it("errors that are not related to a reverted transaction", async function () {
+        // use an address that almost surely doesn't have balance
+        const randomPrivateKey =
+          "0xc5c587cc6e48e9692aee0bf07474118e6d830c11905f7ec7ff32c09c99eba5f9";
+        const signer = new this.hre.ethers.Wallet(
+          randomPrivateKey,
+          this.hre.ethers.provider
+        );
+
+        // this transaction will fail because of lack of funds, not because of a
+        // revert
+        await expect(
+          expect(
+            matchers.connect(signer).revertsWithoutReasonString({
+              gasLimit: 1_000_000,
+            })
+          ).to.not.be.reverted
+        ).to.be.eventually.rejectedWith(
+          "sender doesn't have enough funds to send tx"
+        );
+      });
     });
   }
 });