Skip to content

Commit

Permalink
Merge pull request #4142 from NomicFoundation/re-enable-once-event-test
Browse files Browse the repository at this point in the history
Re-enable hardhat-ethers test
  • Loading branch information
fvictorio committed Jul 12, 2023
2 parents b3661a0 + 1c2a7e8 commit d6ef40a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
3 changes: 1 addition & 2 deletions packages/hardhat-ethers/test/contracts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,7 @@ describe("contracts", function () {
await contract.off("Inc", listener);
});

// temporarily skipped because contract.once doesn't call provider.off
it.skip("should wait for an event using .once", async function () {
it("should wait for an event using .once", async function () {
const signer = await this.env.ethers.provider.getSigner(0);

const factory = new this.env.ethers.ContractFactory<[], ExampleContract>(
Expand Down
7 changes: 4 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4413,6 +4413,7 @@ ethereumjs-util@^7.1.0, ethereumjs-util@^7.1.1, ethereumjs-util@^7.1.2, ethereum
rlp "^2.2.4"

"ethers-v5@npm:ethers@5", ethers@^5.0.0, ethers@^5.0.13, ethers@^5.7.1:
name ethers-v5
version "5.7.2"
resolved "https://registry.yarnpkg.com/ethers/-/ethers-5.7.2.tgz#3a7deeabbb8c030d4126b24f84e525466145872e"
integrity sha512-wswUsmWo1aOK8rR7DIKiWSw9DbLWe6x98Jrn8wcTflTVvaXhAMaB5zGAXy0GYQEQp9iO1iSHWVyARQm11zUtyg==
Expand Down Expand Up @@ -4464,9 +4465,9 @@ ethers@^4.0.0-beta.1, ethers@^4.0.32, ethers@^4.0.40:
xmlhttprequest "1.8.0"

ethers@^6.1.0, ethers@^6.4.0:
version "6.6.2"
resolved "https://registry.yarnpkg.com/ethers/-/ethers-6.6.2.tgz#0b6131b5fa291fec69b7ae379cb6bb2405c505a7"
integrity sha512-vyWfVAj2g7xeZIivOqlbpt7PbS2MzvJkKgsncgn4A/1xZr8Q3BznBmEBRQyPXKCgHmX4PzRQLpnYG7jl/yutMg==
version "6.6.3"
resolved "https://registry.yarnpkg.com/ethers/-/ethers-6.6.3.tgz#9bf11d1bd0f18c7c55087d1a52fdc8f3c33c8bab"
integrity sha512-g8wLXeRWSGDD0T+wsL3pvyc3aYnmxEEAwH8LSoDTDRhRsmJeNs9YMXlNU7ax2caO+zHkeI9MkHiz6rwxEjN4Mw==
dependencies:
"@adraffy/ens-normalize" "1.9.2"
"@noble/hashes" "1.1.2"
Expand Down

0 comments on commit d6ef40a

Please sign in to comment.