-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a warning when the config is empty #1490
Comments
I don't think this is feasible, as a file that doesn't export anything in node is equivalent to one exporting an empty object, and that's a valid config. |
Oh, I know, but I think it's a good trade-off. We can just check |
I took a stab at this, is it something you all think would be useful? It sounds like it still may be up for debate. |
Now I get it, @Endlessline, thanks! I guess I'm ok with that trade-off, as we already print a warning if the user doesn't provide a |
If a user fails to export from the HardhatConfig.{js,ts} file or exports an empty object, we now throw an error. This means updating some of our tests cases which have been using the `{}` object as the base case. Relates to #1490
If a user fails to export from the HardhatConfig.{js,ts} file or exports an empty object, we now throw an error. This means updating some of our tests cases which have been using the `{}` object as the base case. Relates to #1490
If a user fails to export from the HardhatConfig.{js,ts} file or exports an empty object, we now throw an error. This means updating some of our tests cases which have been using the `{}` object as the base case. The docs (including plugin docs) have been updated to reflect that `module.exports = {}` will not work when copied and pasted. Relates to #1490
This is usually indicative of a mistake in HardhatConfig, hence we should warn users. Relates to #1490.
This is usually indicative of a mistake in HardhatConfig, hence we should warn users. Relates to #1490.
This is usually indicative of a mistake in HardhatConfig, hence we should warn users. Relates to #1490.
Fixed in |
An user could make something like this in the config:
and forget to do
export default config
. We should show a warning when that happens.The text was updated successfully, but these errors were encountered: