Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce warnings during sample project installation #3525

Closed
fvictorio opened this issue Jan 3, 2023 · 1 comment
Closed

Reduce warnings during sample project installation #3525

fvictorio opened this issue Jan 3, 2023 · 1 comment
Assignees
Labels
status:ready This issue is ready to be worked on type:improvement

Comments

@fvictorio
Copy link
Member

fvictorio commented Jan 3, 2023

Most warnings come from third-party plugins (solidity-coverage and gas-reporter). If we update some dependencies in those repos, the warnings will go away.

According to @alcuadrado, this is what we need to do:

soldity-coverage > detect-port (Upgrade / Vendor as its tiny and pulls deps)
solidity-coverage > @truffle/provider (Replace)
hardhat-gas-reporter > eth-gas-reporter > mocha (Upgrade)
hardhat-gas-reporter > eth-gas-reporter > request-promise-native (Replace)
hardhat-gas-reporter > eth-gas-reporter > request (Replace)

TODO:

eth-gas-reporter package:

solidity-coverage:

After these changes the packages with the newer and correct versions should be automatically downloaded during the installation.

@fvictorio fvictorio added type:improvement status:ready This issue is ready to be worked on labels Jan 3, 2023
@ChristopherDedominici ChristopherDedominici self-assigned this Sep 18, 2023
@ChristopherDedominici
Copy link
Contributor

External PRs have been merged and the warnings are no longer appearing during the sample project installation.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on type:improvement
Projects
Archived in project
Development

No branches or pull requests

2 participants