This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Bump ethers version #296
Merged
Bump ethers version #296
+1,257
−547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the tests are passing locally except one. This test is also failing in the master branch so it's probably not related to my change. Maybe I have a wrong test configuration? |
This was referenced Sep 26, 2023
No, everything looks good. Apologies, the "tests" here are really crazy - they're a fake mocha test suite which is meant to be visually inspected to make sure the output is formatted correctly. In the fake suite there's a failing unit test which makes sure a table is printed even when hardhat unit tests fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the ethers module version to remove warnings about deprecated packages during installation.