Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Conversation

ChristopherDedominici
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici commented Sep 20, 2023

Update deprecated packages:

  • ethers
  • mocha

Remove deprecated packages:

  • request
  • request-promise-native

@cgewecke
Copy link
Owner

cgewecke commented Sep 22, 2023

@ChristopherDedominici Sorry for a pre-emptive review ... I think this might be a bit tricky. The package is super old.

Maybe PR could be split into a few pieces

  • make changes for newer ethers
  • do something about request
  • bump mocha

I'm happy to do the first two, would you like to just make this one a mocha bump?

@frangio
Copy link
Contributor

frangio commented Sep 22, 2023

See #295

@cgewecke
Copy link
Owner

@ChristopherDedominici If you are continuing with this it will be necessary to rebase against master to get the tests running. The repo was not working with more recent versions of Node.

@frangio Updated mocha in #295 (merged)

@ChristopherDedominici
Copy link
Contributor Author

ChristopherDedominici commented Sep 26, 2023

@cgewecke I split this PR into smaller ones:

@cgewecke
Copy link
Owner

Closing via #299, #297, #296, #295

@cgewecke cgewecke closed this Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants