Add support for custom errors #1525
Conversation
| @@ -45,6 +46,7 @@ export interface SourceReference { | |||
| contract?: string; | |||
| function?: string; | |||
| line: number; | |||
| range: [number, number]; | |||
There was a problem hiding this comment.
I don't get this. Why was this added? Pretty sure I'm missing something.
There was a problem hiding this comment.
This is used in ErrorInferrer.filterRedundantFrames
| type: StackTraceEntryType.CUSTOM_ERROR; | ||
| message: string; | ||
| sourceReference: SourceReference; | ||
| isInvalidOpcodeError: boolean; |
There was a problem hiding this comment.
I don't think this field is necessary. Aren't they always reverts?
There was a problem hiding this comment.
Yes, both for panic and custom errors. I removed it in aced929.
| @@ -84,6 +86,13 @@ export interface PanicErrorStackTraceEntry { | |||
| isInvalidOpcodeError: boolean; | |||
| } | |||
|
|
|||
| export interface CustomErrorStackTraceEntry { | |||
| type: StackTraceEntryType.CUSTOM_ERROR; | |||
| message: string; | |||
There was a problem hiding this comment.
What's the message here? The return data?
There was a problem hiding this comment.
This has the already parsed error message. I'll add a comment explaining that.
| @@ -0,0 +1,46 @@ | |||
| import * as abi from "@ethersproject/abi"; | |||
|
|
|||
| export class AbiHelpers { | |||
The two new directories are custom-errors and panic-codes. There's also the (skipped) try-catch-uncaught which is a known bug. |
|
I tested this with the recent 0.8.5 release of solidity and there is only one test failing. It's a very specific test, and it fails because a redundant frame is not properly removed. I don't think it's a blocker, though, so I'll open an issue to track that and expand on the failing test and why it fails. |
Depends on #1452.