-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: blockscout plugin support #5507
Feature: blockscout plugin support #5507
Conversation
🦋 Changeset detectedLatest commit: 510c80a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I had a call with @rimrakhimov, and we decided to review this and get it merged. The intention of this PR is not to use a different blockscout specific API, but to be able to configure and use blockscout as a first-class citizen like etherscan and sourcify. |
@schaable, once you get back, can you review this? You are more familiar with the different providers that the plugin has. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are a few things I'd like to improve, such as the chain list duplication, general messaging, and updating the docs, but we can leave it for a future iteration.
Tests:
- Each provider individually (Etherscan with constructor args, Sourcify and Blockscout without constructor args).
- All providers simultaneously with constructor args.
- All providers simultaneously without constructor args (Etherscan fails, Sourcify and Blockscout succeed).
- All providers with an already verified contract.
- All providers, with one throwing an error (contract already verified error for Blockscout). This occurred frequently when verifying with all providers. If you visit the contract address in Blockscout, it shows "This contract has been verified using Blockscout Bytecode Database." We may need to update the message to avoid throwing an error in this case.
- All providers throwing an error.
Hi @schaable , thanks for the review! I'm interested if you want us to implement those changes or you've just added them to your internal backlog? We may probably at least make a PR with updates into documentation Also, as further enhancements we discussed with @alcuadrado the possibility to
Wdyt about those changes and what do we need to do to have them added? |
I was quickly testing the plugin. A couple of observations:
await hre.run("verify:verify", {
address: contractAddress,
constructorArguments: constructorArgs,
}); |
Description
The initial blockscout plugin support suggestion: #5224