Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardhat-keystore #5654

Merged
merged 160 commits into from
Sep 10, 2024
Merged

Hardhat-keystore #5654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
160 commits
Select commit Hold shift + click to select a range
c258920
first version without encryption
ChristopherDedominici Aug 19, 2024
54e492e
add tests for the tasks
ChristopherDedominici Aug 21, 2024
accd9da
wrap io in object to allow mock in tests
ChristopherDedominici Aug 21, 2024
13d5284
add hook logic - still in progress
ChristopherDedominici Aug 22, 2024
2cc88b0
update packages in package.json
ChristopherDedominici Aug 23, 2024
389af38
modify the TMP value returned by the default hh fetchValue handler
ChristopherDedominici Aug 23, 2024
a3d8d02
finalize tests
ChristopherDedominici Aug 23, 2024
ae4cfb0
update package files like README, etc
ChristopherDedominici Aug 23, 2024
c13d2df
remove hh-core from file imports
ChristopherDedominici Aug 23, 2024
61803e4
revert change used in manual tests
ChristopherDedominici Aug 23, 2024
9257d82
improve Hardhat error message adding quotes around variable value
ChristopherDedominici Aug 23, 2024
e2fa1b9
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Aug 26, 2024
30294ea
update pnpm-lock file
ChristopherDedominici Aug 26, 2024
2445ba1
update pnpm-lock file
ChristopherDedominici Aug 26, 2024
126e748
add package to changeset pre.json
ChristopherDedominici Aug 26, 2024
3ebb6a8
add dependencies in tsconfig file
ChristopherDedominici Aug 26, 2024
4662e3c
remove dependencies from hh-core
ChristopherDedominici Aug 26, 2024
a807a48
Merge branch 'v-next' into features/keystore-first-version
kanej Aug 28, 2024
16eac2f
refactor: small rename of pluralized variable
kanej Aug 28, 2024
902d170
refactor: remove Foo plugin from built ins
kanej Aug 28, 2024
ee3bc2b
chore: add keystore to example project
kanej Aug 28, 2024
53ad85d
test: fix up tests
kanej Aug 28, 2024
3ce796b
simplify the tests by removing unnecessary mock tests
ChristopherDedominici Aug 28, 2024
d7e8ee4
split test file into tasks and hooks and helpers
ChristopherDedominici Aug 28, 2024
9632d21
refactor: move tasks out to lazy loaded files
kanej Aug 28, 2024
6a1a7ca
refactor: split apart methods file
kanej Aug 28, 2024
54ab7ed
refactor: rename utils to keystore loader
kanej Aug 28, 2024
b7f3035
refactor: rename the Keystore type to KeystoreFile
kanej Aug 28, 2024
ebd3b22
refactor: add basic loader
kanej Aug 28, 2024
983b714
refactor: return a keystore rather than keystore file
kanej Aug 28, 2024
9fce30f
refactor: move ui into its own folder
kanej Aug 28, 2024
a6bdda9
test: split out task tests
kanej Aug 29, 2024
e4410e7
test: cleanup setups where there are existing keys
kanej Aug 29, 2024
e19b354
refactor: fix file name casing
kanej Aug 29, 2024
6ea6e0d
refactor: rename file to raw-interruptions
kanej Aug 29, 2024
d83032e
remove assert files because they are no longer needed
ChristopherDedominici Aug 29, 2024
5c762c5
add tests for UnencryptedKeystore
ChristopherDedominici Aug 29, 2024
347607b
add the new tests for the UnencryptedKeystoreLoader and remove the ol…
ChristopherDedominici Aug 29, 2024
93dd284
make interruptions async because of the hook's interruptions
ChristopherDedominici Aug 29, 2024
0317ed9
modify the hook to support context interruptions
ChristopherDedominici Aug 29, 2024
6b1241f
modify source for importing PLUGIN_ID
ChristopherDedominici Aug 29, 2024
8668c5f
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Aug 29, 2024
e6d0e7e
chore: add c8 to keystore package
kanej Aug 30, 2024
47703b1
add error interruptions for hook
ChristopherDedominici Aug 30, 2024
e4ffd34
modify the get in the hook to use the hook's interrupts
ChristopherDedominici Aug 30, 2024
e72517e
add hook tests
ChristopherDedominici Aug 30, 2024
17d59b9
Merge branch 'features/keystore-first-version' of github.com:NomicFou…
ChristopherDedominici Aug 30, 2024
15b56db
remove unused console.log
ChristopherDedominici Aug 30, 2024
fd322e8
uniform the var names and logs: use value instead of secret
ChristopherDedominici Aug 30, 2024
a354e70
remove old TODOs
ChristopherDedominici Aug 30, 2024
e2aea9a
refactor: move util under ui
kanej Aug 30, 2024
c0dec2e
refactor: switch back to load/create over hasKeystore
kanej Aug 30, 2024
f5de10b
refactor: collapse fns in loader
kanej Aug 30, 2024
d92948f
refactor: pull filepath load up and out
kanej Aug 30, 2024
a7b006d
refactor: use util for construction
kanej Aug 30, 2024
df6419b
refactor: move the UI element out of validate key
kanej Aug 30, 2024
8dc1dc2
refactor: pull out the arg check
kanej Aug 30, 2024
0122068
refactor: wrap messages
kanej Aug 30, 2024
f8b8107
test: reduce mock to console wrapper
kanej Aug 31, 2024
dae23b8
fix: switching the name to value in line with api changes
kanej Aug 31, 2024
6d69872
refactor: remove isAuthorized
kanej Aug 31, 2024
5d2d00e
refactor: all tasks should return Promise<void>
kanej Aug 31, 2024
b70783d
refactor: move responsibility for writing to loader
kanej Aug 31, 2024
d6b37e4
refactor: make loader generic
kanej Aug 31, 2024
9f63f06
refactor: add exists to loader
kanej Aug 31, 2024
22537f8
refactor: add a `hasKeys` to keystore
kanej Aug 31, 2024
0871eaf
test: move tests to reflect previous refactorings
kanej Aug 31, 2024
ea9425b
refactor: rename of the ui elements
kanej Aug 31, 2024
564e7d3
refactor: move to using the user interruption interface directly
kanej Aug 31, 2024
a48aa76
refactor: class name cleanup
kanej Aug 31, 2024
f6ea63a
refactor: remove unneeded user interactions interface
kanej Aug 31, 2024
01ca990
fix: use context based interruptions for hook
kanej Aug 31, 2024
3f6c746
refactor: pull filestore path from config
kanej Sep 1, 2024
5f18883
test: add integration tests for tasks
kanej Sep 1, 2024
218cca3
Merge branch 'v-next' into features/keystore-first-version
kanej Sep 2, 2024
e77c5af
test: include set in integration tests
kanej Sep 2, 2024
e9ccd58
test: exclude types from coverage
kanej Sep 2, 2024
ccd9b71
add caching mechanism for the hook
ChristopherDedominici Sep 2, 2024
aaebf27
test: small fix for easier understanding
kanej Sep 2, 2024
8ba962d
Merge branch 'v-next' into features/keystore-first-version
kanej Sep 2, 2024
64a4875
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Sep 2, 2024
7e4ee04
fix ArgumentType import
ChristopherDedominici Sep 2, 2024
2f79cd5
test: rename local variables to match type
kanej Sep 2, 2024
e09a37c
test: restructure to one assertion per it
kanej Sep 2, 2024
43c7c18
refactor: explicit factory for keystore file
kanej Sep 2, 2024
fc424a8
refactor: move to internal folder
kanej Sep 2, 2024
3f0278e
test: split out into scenarios
kanej Sep 3, 2024
a5c7b5f
refactor: pull out file manager abstraction
kanej Sep 3, 2024
8bc85a5
refactor: delete unused test helper
kanej Sep 3, 2024
2422a09
chore: fix coverage after internal move
kanej Sep 3, 2024
356d406
refactor: remove unused user type
kanej Sep 3, 2024
0f41240
hook: add test to cover the cache equal to null scenario
ChristopherDedominici Sep 3, 2024
0e2061f
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Sep 3, 2024
9e1bade
tmp commit - remove keystore dependency from example-project
ChristopherDedominici Sep 4, 2024
5c20b1a
tmp - re-add keystore dependency in example-project
ChristopherDedominici Sep 4, 2024
a21dca9
remove unused check for undefined key
ChristopherDedominici Sep 4, 2024
2d6e8f0
add zod validation for keystore file
ChristopherDedominici Sep 4, 2024
8e6ce02
fix inline plugin warning
ChristopherDedominici Sep 4, 2024
c51d75e
use hardhat errors instead of plugin errors
ChristopherDedominici Sep 4, 2024
d3e8cc8
move hardhat as peer dependency
ChristopherDedominici Sep 4, 2024
0840e27
fix number in error descriptors
ChristopherDedominici Sep 4, 2024
54f9666
fix file paths: use node:path
ChristopherDedominici Sep 4, 2024
d4de7d8
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Sep 4, 2024
5030143
update lock file
ChristopherDedominici Sep 4, 2024
da8badc
refactor: reduce mocking
kanej Sep 4, 2024
1754240
test: cleanup test setup based on keystore file
kanej Sep 4, 2024
fb347a8
refactor: move test file to match src file
kanej Sep 4, 2024
21ad7ce
refactor: move keystore file creation function to class
kanej Sep 4, 2024
e939568
refactor: remove unused helper
kanej Sep 4, 2024
7f534b4
refactor: remove factory for keystore
kanej Sep 4, 2024
b8f3c13
refactor: remove init and assertions
kanej Sep 4, 2024
67bf1e2
refactor: minor rename
kanej Sep 4, 2024
5788444
test: move loading test to loader
kanej Sep 4, 2024
b445a39
test: bring back the password tests
kanej Sep 4, 2024
6a18cce
refactor: switch to node test mock in the file manager
kanej Sep 5, 2024
4e724d3
test: refactor to gather output on user mock
kanej Sep 5, 2024
549918a
refactor: reformat
kanej Sep 5, 2024
63b9def
refactor: change name of error
kanej Sep 5, 2024
f47ce10
feat: turn off plugin in CI
kanej Sep 5, 2024
a5255c5
revert: fix inline plugin warning
ChristopherDedominici Sep 5, 2024
e4ff8d4
add --force flag for the delete task
ChristopherDedominici Sep 5, 2024
8d427f2
add debug entry in config.ts to show the keystore file path
ChristopherDedominici Sep 5, 2024
b544b41
exit with code 1 when there are user errors
ChristopherDedominici Sep 5, 2024
f2e45bf
docs: add a comment to util
kanej Sep 5, 2024
e73b425
test: add integration test for turning of in CI
kanej Sep 6, 2024
e9beb69
docs: text tweak
kanej Sep 6, 2024
896f512
refactor: rework caching
kanej Sep 6, 2024
d6d125e
refactor: switch keystore api for get
kanej Sep 6, 2024
22962cb
feat: add caching in loader
kanej Sep 6, 2024
331bef2
test: add caching unit tests
kanej Sep 6, 2024
bd072a4
docs: update title in readme
kanej Sep 6, 2024
045a620
refactor: add an assertion
kanej Sep 6, 2024
f3862b1
use 'deleted' instead of 'removed'
ChristopherDedominici Sep 6, 2024
0d6d3ae
Merge branch 'features/keystore-first-version' of github.com:NomicFou…
ChristopherDedominici Sep 6, 2024
6b83787
fix typos
ChristopherDedominici Sep 6, 2024
5468040
remove unused type Format
ChristopherDedominici Sep 6, 2024
5883dab
refactor: rename the loader method
kanej Sep 6, 2024
eb29783
refactor: rename save on loader
kanej Sep 6, 2024
232307d
set "only allow HH errors" in .eslintrc config file
ChristopherDedominici Sep 8, 2024
77be789
remove optional 'onlyHardhatError' - default is true
ChristopherDedominici Sep 9, 2024
e7b5ff9
refactor: switch to in hook CI check
kanej Sep 9, 2024
747a5b5
Cleanup validate password
ChristopherDedominici Sep 9, 2024
611e67e
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Sep 9, 2024
8dc19b6
Merge branch 'features/keystore-first-version' of github.com:NomicFou…
ChristopherDedominici Sep 9, 2024
0b38d3f
add `pretest:only` script in package.json
ChristopherDedominici Sep 9, 2024
f9a76d7
test: fix the config variables hook tests with CI
kanej Sep 9, 2024
b219cdf
use ensure error
ChristopherDedominici Sep 9, 2024
1be7ff2
Merge branch 'features/keystore-first-version' of github.com:NomicFou…
ChristopherDedominici Sep 9, 2024
8de0fe9
docs: comment on the responsiblities of the KeystoreLoader
kanej Sep 9, 2024
ec87a80
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Sep 9, 2024
d843e7a
use getConfigDir from hh-utils
ChristopherDedominici Sep 9, 2024
b900847
Merge branch 'features/keystore-first-version' of github.com:NomicFou…
ChristopherDedominici Sep 9, 2024
987ef4a
HACK: this is a test of the CI
kanej Sep 9, 2024
1b4ab47
test: turn off CI for github actions
kanej Sep 9, 2024
7b7c562
HACK: print the build associated env properties
kanej Sep 9, 2024
f7614d7
fix: test CI for both github actions and CI
kanej Sep 9, 2024
f0efbb0
refactor: remove user interruptions abstraction
kanej Sep 9, 2024
fb37724
refactor: clean up keystore loader factory fn
kanej Sep 9, 2024
85034d4
Merge branch 'v-next' of github.com:NomicFoundation/hardhat into feat…
ChristopherDedominici Sep 10, 2024
3b7f03b
update pnpm file
ChristopherDedominici Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changeset/pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"@ignored/hardhat-vnext": "2.0.0",
"@ignored/hardhat-vnext-build-system": "2.0.0",
"@ignored/hardhat-vnext-errors": "2.0.0",
"@ignored/hardhat-vnext-keystore": "2.0.0",
"@ignored/hardhat-vnext-node-test-reporter": "2.0.0",
"@ignored/hardhat-vnext-utils": "2.0.0",
"@ignored/hardhat-vnext-zod-utils": "2.0.0",
Expand Down
Loading