fix: hardhat-chai-matchers - add check byte32 string to reverted matcher

[iosh]

• Because this PR includes a bug fix, relevant tests have been included.
• Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
• I didn't do anything of this.

---

Add when receipt is null, check if value is a byte32 string. minimal changes were in PRto resolve #4725

I see the following comment in the code

        // If the subject of the assertion is not connected to a transaction
        // (hash, receipt, etc.), then the assertion fails.
        // Since we use `false` here, this means that `.not.to.be.reverted`
        // assertions will pass instead of always throwing a validation error.
        // This allows users to do things like:
        //   `expect(c.callStatic.f()).to.not.be.reverted`
        assert(false, "Expected transaction to be reverted");

So i think maybe we can change the check to :

      if (
        isTransactionResponse(value) ||
        (typeof value === "string" && isValidTransactionHash(value))
      ) {
        const hash = typeof value === "string" ? value : value.hash;

        // if (!isValidTransactionHash(hash)) {
        //   throw new TypeError(
        //     `Expected a valid transaction hash, but got '${hash}'`
        //   );
        // }

This way, we can enable other data types to pass the test, but they will be broken change.

[changeset-bot]

🦋 Changeset detected

Latest commit: 36a8891

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@nomicfoundation/hardhat-chai-matchers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 12, 2024 7:55pm

[iosh]

I think it also can throw an error:

 throw new TypeError(
            `Expected a valid transaction hash, but got bytes32  '${hash}'`
       )

[schaable]

Looks good. Tested with the code example provided in the issue and it works. Thanks @iosh!