-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for solc versions 0.8.25, 0.8.26, and 0.8.27 #5740
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0e30f4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6c6dcfd
to
ddadd4c
Compare
@schaable I restored the option to run tests for all solc versions in CI (in #5745) and kicked off a run that has the changes introduced in this PR - https://github.com/NomicFoundation/hardhat/actions/runs/10846884277. As you can see it fails with OOMs, do you think that's something we should look into more? Other than that, it looks good to me, but wanted to check with you first. |
To be honest, I’m not sure. It doesn’t seem directly related to adding the |
@fvictorio, what's the status of these tests now that more things are ported to Rust? Should we still run them here? |
@alcuadrado yes. We are working right now to complete the migration. After that (and after helping adapts solc's CI to run on EDR) we'll be able to remove the stack traces tests from the Hardhat repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appproving despite the OOM that @galargh discovered, as that's a CI workflow that we don't usually run, and will be moved to EDR soon.
This PR adds support for Solidity versions 0.8.25, 0.8.26, and 0.8.27, and updates the default/latest Solidity version to 0.8.27.
Closes #5723