Enable stack traces in the EDR provider #6214

alcuadrado · 2025-01-31T21:41:43Z

While cleaning up the ArtifactsManager interface in #6213 I noticed that we may have a misalignment between the build info formats that EDR was expecting and the ones we generated, so I took a stab at this.

This PR those a few things:

Sets the correct types in our own EDR node-types, as for some reason EDR is using some anys.
It loads and converts all the build infos into the expected format.
Adds the artifacts plugin as a dependency of the network manager plugin, so that it can load the build infos
Fixes an issue related to how we were creating the solc inputs.

While this closes #5981, there's going to be a bit of follow up work.

Once Agost releases a new version of @ignored/edr, we should do something similar for the solidity tests. Except without transforming the build infos into HH2 build infos.
Once Remco adapts the interface of @ignored/edr-optimism, we should stop parsing and transforming the build infos in the NetworkManager.
We should test this integration, as right now its only "tested" in the example project.

changeset-bot · 2025-01-31T21:41:47Z

⚠️ No Changeset found

Latest commit: 8484d3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package "@nomicfoundation/ignition-core" depends on the ignored package "hardhat", but "@nomicfoundation/ignition-core" is not being ignored. Please add "@nomicfoundation/ignition-core" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition-ethers" depends on the ignored package "hardhat", but "@nomicfoundation/hardhat-ignition-ethers" is not being ignored. Please add "@nomicfoundation/hardhat-ignition-ethers" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition-viem" depends on the ignored package "hardhat", but "@nomicfoundation/hardhat-ignition-viem" is not being ignored. Please add "@nomicfoundation/hardhat-ignition-viem" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition" depends on the ignored package "hardhat", but "@nomicfoundation/hardhat-ignition" is not being ignored. Please add "@nomicfoundation/hardhat-ignition" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition-ethers" depends on the ignored package "@nomicfoundation/hardhat-ethers", but "@nomicfoundation/hardhat-ignition-ethers" is not being ignored. Please add "@nomicfoundation/hardhat-ignition-ethers" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition" depends on the ignored package "@nomicfoundation/hardhat-network-helpers", but "@nomicfoundation/hardhat-ignition" is not being ignored. Please add "@nomicfoundation/hardhat-ignition" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition" depends on the ignored package "@nomicfoundation/hardhat-verify", but "@nomicfoundation/hardhat-ignition" is not being ignored. Please add "@nomicfoundation/hardhat-ignition" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition-viem" depends on the ignored package "@nomicfoundation/hardhat-viem", but "@nomicfoundation/hardhat-ignition-viem" is not being ignored. Please add "@nomicfoundation/hardhat-ignition-viem" to the `ignore` option.
The package "@nomicfoundation/ignition-core" depends on the ignored package "@nomicfoundation/eslint-plugin-hardhat-internal-rules", but "@nomicfoundation/ignition-core" is not being ignored. Please add "@nomicfoundation/ignition-core" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition-ethers" depends on the ignored package "@nomicfoundation/eslint-plugin-hardhat-internal-rules", but "@nomicfoundation/hardhat-ignition-ethers" is not being ignored. Please add "@nomicfoundation/hardhat-ignition-ethers" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition-viem" depends on the ignored package "@nomicfoundation/eslint-plugin-hardhat-internal-rules", but "@nomicfoundation/hardhat-ignition-viem" is not being ignored. Please add "@nomicfoundation/hardhat-ignition-viem" to the `ignore` option.
The package "@nomicfoundation/hardhat-ignition" depends on the ignored package "@nomicfoundation/eslint-plugin-hardhat-internal-rules", but "@nomicfoundation/hardhat-ignition" is not being ignored. Please add "@nomicfoundation/hardhat-ignition" to the `ignore` option.

vercel · 2025-01-31T21:41:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 3, 2025 2:56pm

alcuadrado · 2025-01-31T22:16:58Z

@galargh as I changed how the solc inputs are generated, some build ids changed, and that broke a test. Can you check if my fix is correct?

schaable

Looks good, but left a question regarding performance.

schaable · 2025-02-03T14:22:00Z

v-next/example-project/test/node/example-test.ts

+    } catch (error) {
+      assert.ok(error instanceof Error, "Expected an error to be thrown");
+
+      assert.ok(


no need to change it, but there's an assert.match that better captures this type of assertion.

Thanks! I looked for something with "includes" semantics and couldn't find any 😅

schaable · 2025-02-03T14:28:24Z

v-next/hardhat/src/internal/builtin-plugins/network-manager/network-manager.ts

@@ -204,6 +214,10 @@ export class NetworkManagerImplementation implements NetworkManager {
            chainType: resolvedChainType as ChainType,
          },
          jsonRpcRequestWrapper,
+          tracingConfig: {


have you seen any performance hit after adding this? I thought it would be disabled by default and enabled through config.

It's meant to be enabled by default, so if there's any performance issue we should address it.

Right now it will have a small performance problem, which is being address in EDR. Note that we are parsing and transforming the build infos, just to pass it to EDR.

In the near future we'll just pass the Uint8Array read from the files, directly.

galargh

Looks good! In 7ebad19 (which is part of #6129), I refactored the build-system.ts as I found it very annoying up to update.

Having said that, we can go ahead with these changes first, and I'll deal with resolving the conflicts.

alcuadrado requested review from schaable and galargh January 31, 2025 21:41

github-actions bot added the status:ready This issue is ready to be worked on label Jan 31, 2025

alcuadrado linked an issue Jan 31, 2025 that may be closed by this pull request

EDR not getting compilation results in v3 #5981

Closed

vercel bot temporarily deployed to Preview January 31, 2025 22:17 Inactive

vercel bot temporarily deployed to Preview January 31, 2025 22:19 Inactive

alcuadrado force-pushed the pass-build-infos-to-edr branch from 51fc3f0 to 0e77fd4 Compare February 2, 2025 17:11

vercel bot temporarily deployed to Preview February 2, 2025 17:13 Inactive

schaable approved these changes Feb 3, 2025

View reviewed changes

alcuadrado added 8 commits February 3, 2025 14:49

Use HH2 build infos in the EDR provider config

bcf7fea

Add the artifacts plugin as a dependency of the network manager

5ffd707

Pass the ArtifactManager to the NetworkManager

9c185f2

Load all the build infos and their outputs

9726102

Fix how we create solc inputs

518c280

Add a "test" in the example-project

cea690a

Regenerate fixtures

02163a6

Fix linter errors

c40d264

alcuadrado force-pushed the pass-build-infos-to-edr branch from 0e77fd4 to c40d264 Compare February 3, 2025 14:49

vercel bot temporarily deployed to Preview February 3, 2025 14:50 Inactive

Update after rebasing on top of cleanup-artifacts

8484d3c

vercel bot temporarily deployed to Preview February 3, 2025 14:56 Inactive

galargh approved these changes Feb 3, 2025

View reviewed changes

Base automatically changed from cleanup-artifacts to v-next February 4, 2025 20:04

alcuadrado added this pull request to the merge queue Feb 4, 2025

Merged via the queue into v-next with commit 43d6557 Feb 4, 2025
60 checks passed

alcuadrado deleted the pass-build-infos-to-edr branch February 4, 2025 20:16

github-actions bot locked as resolved and limited conversation to collaborators May 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable stack traces in the EDR provider #6214

Enable stack traces in the EDR provider #6214

Uh oh!

alcuadrado commented Jan 31, 2025

Uh oh!

changeset-bot bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

alcuadrado commented Jan 31, 2025 •

edited by kanej

Loading

Uh oh!

schaable left a comment

Uh oh!

schaable Feb 3, 2025

Uh oh!

alcuadrado Feb 3, 2025

Uh oh!

schaable Feb 3, 2025

Uh oh!

alcuadrado Feb 3, 2025 •

edited

Loading

Uh oh!

galargh left a comment

Uh oh!

Uh oh!

Uh oh!

Enable stack traces in the EDR provider #6214

Enable stack traces in the EDR provider #6214

Uh oh!

Conversation

alcuadrado commented Jan 31, 2025

Uh oh!

changeset-bot bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alcuadrado commented Jan 31, 2025 • edited by kanej Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schaable left a comment

Choose a reason for hiding this comment

Uh oh!

schaable Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

alcuadrado Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

schaable Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

alcuadrado Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

galargh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Jan 31, 2025 •

edited

Loading

vercel bot commented Jan 31, 2025 •

edited

Loading

alcuadrado commented Jan 31, 2025 •

edited by kanej

Loading

alcuadrado Feb 3, 2025 •

edited

Loading