support dots in yul identifiers from 0.5.8 till 0.7.0

Closes #743

.changeset/cool-numbers-sneeze.md

@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/slang": patch
+---
+
+support dots in yul identifiers from `0.5.8` till `0.7.0`

crates/solidity/inputs/language/src/definition.rs

@@ -3946,14 +3946,12 @@ codegen_language_macros::compile!(Language(
                         ),
                         Token(
                             name = Identifier,
-                            definitions = [TokenDefinition(scanner = Fragment(RawIdentifier))]
-                        ),
-                        Fragment(
-                            name = RawIdentifier,
-                            scanner = Sequence([
-                                Fragment(IdentifierStart),
-                                ZeroOrMore(Fragment(IdentifierPart))
-                            ])
+                            definitions = [TokenDefinition(
+                                scanner = Sequence([
+                                    Fragment(IdentifierStart),
+                                    ZeroOrMore(Fragment(IdentifierPart))
+                                ])
+                            )]
                         ),
                         Fragment(
                             name = IdentifierStart,
@@ -4199,7 +4197,23 @@ codegen_language_macros::compile!(Language(
                         ),
                         Token(
                             name = YulIdentifier,
-                            definitions = [TokenDefinition(scanner = Fragment(RawIdentifier))]
+                            definitions = [
+                                // Dots were allowed specifically between these versions:
+                                TokenDefinition(
+                                    enabled = Range(from = "0.5.8", till = "0.7.0"),
+                                    scanner = Sequence([
+                                        Fragment(IdentifierStart),
+                                        ZeroOrMore(Choice([Fragment(IdentifierPart), Atom(".")]))
+                                    ])
+                                ),
+                                // Otherwise, parse as a regular identifier:
+                                TokenDefinition(
+                                    scanner = Sequence([
+                                        Fragment(IdentifierStart),
+                                        ZeroOrMore(Fragment(IdentifierPart))
+                                    ])
+                                )
+                            ]
                         ),
                         Enum(
                             name = YulBuiltInFunction,

crates/solidity/testing/snapshots/cst_output/YulExpression/identifier_path/generated/0.4.11-success.yml

@@ -1,12 +1,15 @@
 # This file is generated automatically by infrastructure scripts. Please don't edit by hand.
 
 Source: >
-  1  │ foo.bar                                                                          │ 0..7
+  1  │ foo . bar                                                                        │ 0..9
 
 Errors: []
 
 Tree:
-  - (YulExpression) ► (variant꞉ YulIdentifierPath): # "foo.bar" (0..7)
+  - (YulExpression) ► (variant꞉ YulIdentifierPath): # "foo . bar\n" (0..10)
       - (item꞉ YulIdentifier): "foo" # (0..3)
-      - (separator꞉ Period): "." # (3..4)
-      - (item꞉ YulIdentifier): "bar" # (4..7)
+      - (LeadingTrivia) ► (Whitespace): " " # (3..4)
+      - (separator꞉ Period): "." # (4..5)
+      - (LeadingTrivia) ► (Whitespace): " " # (5..6)
+      - (item꞉ YulIdentifier): "bar" # (6..9)
+      - (TrailingTrivia) ► (EndOfLine): "\n" # (9..10)

crates/solidity/testing/snapshots/cst_output/YulExpression/identifier_path/input.sol

@@ -1 +1 @@
-foo.bar
+foo . bar

crates/solidity/testing/snapshots/cst_output/YulExpression/identifier_with_dot/generated/0.4.11-success.yml

@@ -0,0 +1,17 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ // identifiers with dots were allowed specifically from = "0.5.8" till = "0.7.0": │ 0..81
+  2  │ foo.bar                                                                           │ 82..89
+
+Errors: []
+
+Tree:
+  - (YulExpression) ► (variant꞉ YulIdentifierPath): # "// identifiers with dots were allowed specifically..." (0..90)
+      - (LeadingTrivia): # "// identifiers with dots were allowed specifically..." (0..82)
+          - (SingleLineComment): "// identifiers with dots were allowed specifically..." # (0..81)
+          - (EndOfLine): "\n" # (81..82)
+      - (item꞉ YulIdentifier): "foo" # (82..85)
+      - (separator꞉ Period): "." # (85..86)
+      - (item꞉ YulIdentifier): "bar" # (86..89)
+      - (TrailingTrivia) ► (EndOfLine): "\n" # (89..90)

crates/solidity/testing/snapshots/cst_output/YulExpression/identifier_with_dot/generated/0.5.8-success.yml

@@ -0,0 +1,15 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ // identifiers with dots were allowed specifically from = "0.5.8" till = "0.7.0": │ 0..81
+  2  │ foo.bar                                                                           │ 82..89
+
+Errors: []
+
+Tree:
+  - (YulExpression) ► (variant꞉ YulIdentifierPath): # "// identifiers with dots were allowed specifically..." (0..90)
+      - (LeadingTrivia): # "// identifiers with dots were allowed specifically..." (0..82)
+          - (SingleLineComment): "// identifiers with dots were allowed specifically..." # (0..81)
+          - (EndOfLine): "\n" # (81..82)
+      - (item꞉ YulIdentifier): "foo.bar" # (82..89)
+      - (TrailingTrivia) ► (EndOfLine): "\n" # (89..90)

crates/solidity/testing/snapshots/cst_output/YulExpression/identifier_with_dot/generated/0.7.0-success.yml

@@ -0,0 +1,17 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ // identifiers with dots were allowed specifically from = "0.5.8" till = "0.7.0": │ 0..81
+  2  │ foo.bar                                                                           │ 82..89
+
+Errors: []
+
+Tree:
+  - (YulExpression) ► (variant꞉ YulIdentifierPath): # "// identifiers with dots were allowed specifically..." (0..90)
+      - (LeadingTrivia): # "// identifiers with dots were allowed specifically..." (0..82)
+          - (SingleLineComment): "// identifiers with dots were allowed specifically..." # (0..81)
+          - (EndOfLine): "\n" # (81..82)
+      - (item꞉ YulIdentifier): "foo" # (82..85)
+      - (separator꞉ Period): "." # (85..86)
+      - (item꞉ YulIdentifier): "bar" # (86..89)
+      - (TrailingTrivia) ► (EndOfLine): "\n" # (89..90)

crates/solidity/testing/snapshots/cst_output/YulExpression/identifier_with_dot/input.sol

@@ -0,0 +1,2 @@
+// identifiers with dots were allowed specifically from = "0.5.8" till = "0.7.0":
+foo.bar