-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misleading QueryError
on misspelled labels or kinds
#1042
Comments
QueryError
on misspelled labelsQueryError
on misspelled labels or kinds
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 2, 2024
Fixes #1041 Fixes #1042 This PR improves on the query parse errors reported: - Compute row and column information for query parser errors (previously these were not computed and hard-coded to 0,0) - Improve reporting when the error occurs attempting to parse edge labels or node kinds: By using `cut()` and providing a `context()` we can get a better error message without fully customizing the error type used throughout the parser.
ggiraldez
added a commit
to manastech/slang
that referenced
this issue
Aug 6, 2024
Fixes NomicFoundation#1041 Fixes NomicFoundation#1042 This PR improves on the query parse errors reported: - Compute row and column information for query parser errors (previously these were not computed and hard-coded to 0,0) - Improve reporting when the error occurs attempting to parse edge labels or node kinds: By using `cut()` and providing a `context()` we can get a better error message without fully customizing the error type used throughout the parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Error:
Name:
withname:
.nom
alternative, maybe we can parse the identifier, and produce an error (at the identifier location) explaining why it is not a validTerminalKind
,NonterminalKind
, orNodeLabel
?The text was updated successfully, but these errors were encountered: