Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string literals should accept unicode characters before 0.7.0 #784

Closed
OmarTawfik opened this issue Feb 8, 2024 · 0 comments · Fixed by #800
Closed

string literals should accept unicode characters before 0.7.0 #784

OmarTawfik opened this issue Feb 8, 2024 · 0 comments · Fixed by #800
Assignees
Labels
bug Something isn't working

Comments

@OmarTawfik
Copy link
Collaborator

OmarTawfik commented Feb 8, 2024

The following string literal is legal until 0.7.0. Afterwards, it became disallowed after the introduction of UnicodeStringLiteral:

contract Test {
    event Bar(string y);

    function foo() public {
        emit Bar("Fireworks 🎆");
    }
}
@OmarTawfik OmarTawfik added the bug Something isn't working label Feb 8, 2024
@OmarTawfik OmarTawfik self-assigned this Feb 12, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 12, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 20, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 21, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 22, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 22, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 22, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant