Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Rule/Token => Nonterminal/Terminal rename #834

Closed
3 tasks done
Xanewok opened this issue Feb 19, 2024 · 0 comments · Fixed by #971
Closed
3 tasks done

Consider Rule/Token => Nonterminal/Terminal rename #834

Xanewok opened this issue Feb 19, 2024 · 0 comments · Fixed by #971
Assignees
@Xanewok

Comments

@Xanewok
Copy link
Member

Xanewok commented Feb 19, 2024 •
edited by OmarTawfik
Loading

Split from #640.

  • Rename TokenKind to TerminalKind, since it will also refer to trivia.
  • Rename RuleKind to NonTerminalKind, since "rule" is ambiguous.
  • Rename LabelKind to EdgeKind, and LabeledXXX to Edge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
None yet
Projects
No open projects
Slang - 2024 H1
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: Rename RuleKind, TokenKind and NodeLabel Xanewok/slang
1 participant
@Xanewok