-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation for AST operator types #872
Comments
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this issue
Jun 10, 2024
Uses labels to select AST nodes, which is more accurate, requires less code (instead of checking individual kinds), and also fixes a bug where additional `TerminalKind`s of `PrecedenceOperator` are not taken into account. Closes NomicFoundation#872 Closes NomicFoundation#986
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this issue
Jun 10, 2024
Uses labels to select AST nodes, which is more accurate, requires less code (instead of checking individual kinds), and also fixes a bug where additional `TerminalKind`s of `PrecedenceOperator` are not taken into account. Closes NomicFoundation#872 Closes NomicFoundation#986
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this issue
Jun 10, 2024
Uses labels to select AST nodes, which is more accurate, requires less code (instead of checking individual kinds), and also fixes a bug where additional `TerminalKind`s of `PrecedenceOperator` are not taken into account. Closes NomicFoundation#872 Closes NomicFoundation#986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please check the
TODO(#872)
comments added in #873.The text was updated successfully, but these errors were encountered: