Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cargo workspace publishing #1007

Merged

Conversation

OmarTawfik
Copy link
Collaborator

@OmarTawfik OmarTawfik commented Jun 12, 2024

Currently our publishing pipeline is failing to publish workspace crates that have internal dependencies:
https://github.com/NomicFoundation/slang/actions/runs/9468852124/job/26088399371

error: all dependencies must have a version specified when publishing.
  dependency `metaslang_cst` does not specify a version

This is a known bug/limitation of cargo publish: rust-lang/cargo#11133

To get around this, I'm explicitly adding versions to all internal dependencies, and switching our versioning workflow to use cargo set-version to update all of them when creating the changesets PR.

@OmarTawfik OmarTawfik requested a review from a team as a code owner June 12, 2024 11:06
Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: 2242278

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik changed the title fi cargo workspace publishing fix cargo workspace publishing Jun 12, 2024
@OmarTawfik OmarTawfik added this pull request to the merge queue Jun 12, 2024
Merged via the queue into NomicFoundation:main with commit 43f22df Jun 12, 2024
1 of 3 checks passed
@OmarTawfik OmarTawfik deleted the fix-cargo-publishing branch June 12, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants