upgrade rust to latest version #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: af60896 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Xanewok
approved these changes
Jun 17, 2024
crates/metaslang/cst/src/cursor.rs
Outdated
| @@ -49,7 +49,7 @@ impl<T: KindTypes> Cursor<T> { | |||
| } | |||
|
|
|||
| fn set_from_ancestor_node(&mut self, ancestor: &Rc<PathAncestor<T>>) { | |||
| self.parent = ancestor.parent.clone(); | |||
| self.parent.clone_from(&ancestor.parent); | |||
There was a problem hiding this comment.
It's so rarely used in practice to the point where this looks less immediately clear than a = b.clone() for me but I don't want to block as it's a minor thing.
There was a problem hiding this comment.
@Xanewok this was produced by https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones
I'm not sure how common it is to use clone_from() in external crates is, and I agree the code is a bit less readable this way. I don't see a way to silence this rule on specific types (Rc<>, etc...). Should we just disable it?
There was a problem hiding this comment.
I think so. We can re-enable it once we want to eek out more performance (the Clone::clone_from exists to reuse certain allocations when cloning).
(fun fact, the derive(Clone) machinery does not use that and uses Clone::clone directly due to the sheer codegen impact and thus boostrap/compile timings in rustc while not always bringing perf benefits).
|
Removed from the queue in case you agree with #1015 (comment), if not, feel free to re-add it again. |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/slang@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-darwin-arm64@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-darwin-x64@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-linux-arm64-gnu@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-linux-arm64-musl@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-linux-x64-gnu@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-linux-x64-musl@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-win32-arm64-msvc@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-win32-ia32-msvc@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` ## @nomicfoundation/slang-win32-x64-msvc@0.16.0 ### Minor Changes - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: queries now ignore trivia nodes. - [#1030](#1030) [`7e467ce`](7e467ce) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: remove the ellipsis query `...` operator making it implicit, add an adjacency operator `.`. ### Patch Changes - [#1015](#1015) [`369ee30`](369ee30) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust `1.79.0`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Compute row and column information for query parser errors. - [#1048](#1048) [`c408caa`](c408caa) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support Yul multiple variables declaration - [#1047](#1047) [`2b32045`](2b32045) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inline `MemberAccess` enum into the parent `MemberAccessExpression` - [#1062](#1062) [`6b05496`](6b05496) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix stack assignments operator `=:`. - [#1052](#1052) [`54c9067`](54c9067) Thanks [@ggiraldez](https://github.com/ggiraldez)! - Tree Query Language: Improve reporting when an error occurs attempting to parse edge labels or node kinds. - [#1037](#1037) [`2a74f91`](2a74f91) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix `ExponentiationExpression` associativity before `0.8.0` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.