Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version pragma grammar to be more constrained #1086

Conversation

AntonyBlakey
Copy link
Contributor

No description provided.

@AntonyBlakey AntonyBlakey requested a review from a team as a code owner August 21, 2024 15:04
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 8576a85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@nomicfoundation/slang Patch
@nomicfoundation/slang-darwin-arm64 Patch
@nomicfoundation/slang-darwin-x64 Patch
@nomicfoundation/slang-linux-arm64-gnu Patch
@nomicfoundation/slang-linux-arm64-musl Patch
@nomicfoundation/slang-linux-x64-gnu Patch
@nomicfoundation/slang-linux-x64-musl Patch
@nomicfoundation/slang-win32-arm64-msvc Patch
@nomicfoundation/slang-win32-ia32-msvc Patch
@nomicfoundation/slang-win32-x64-msvc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AntonyBlakey AntonyBlakey self-assigned this Aug 21, 2024
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/more-specific-version-pragma-grammar branch from a5d8cd9 to b0a1d68 Compare August 21, 2024 15:06
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions. Thanks!

@AntonyBlakey AntonyBlakey added this pull request to the merge queue Aug 23, 2024
"@nomicfoundation/slang": patch
---

The grammar for VersionExpressionSet has changed to more accurately model the allowed structure.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit suggestion. Not blocking of course:

Suggested change
The grammar for VersionExpressionSet has changed to more accurately model the allowed structure.
The grammar for `VersionExpressionSet` has changed to more accurately model the allowed structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@OmarTawfik OmarTawfik removed this pull request from the merge queue due to a manual request Aug 23, 2024
@AntonyBlakey AntonyBlakey added this pull request to the merge queue Aug 23, 2024
Merged via the queue into NomicFoundation:main with commit f749e53 Aug 23, 2024
1 check passed
@AntonyBlakey AntonyBlakey deleted the AntonyBlakey/more-specific-version-pragma-grammar branch August 23, 2024 13:16
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/slang@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-darwin-arm64@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-darwin-x64@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-linux-arm64-gnu@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-linux-arm64-musl@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-linux-x64-gnu@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-linux-x64-musl@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-win32-arm64-msvc@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-win32-ia32-msvc@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

## @nomicfoundation/slang-win32-x64-msvc@0.17.0

### Minor Changes

- [#1079](#1079)
[`43b389e`](43b389e)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move the Rust CLI
into a separate `slang_solidity_cli` crate.

### Patch Changes

- [#1086](#1086)
[`f749e53`](f749e53)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - The grammar
for `VersionExpressionSet` has changed to more accurately model the
allowed structure.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants