Split binding rules into multiple parts and process built-ins with a subset #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggiraldez
force-pushed
the
split-rules
branch
from
765ef17 to
6104e29
Compare
This is both for maintainability and to be able to select a subset of the rules for processing built-ins.
ggiraldez
force-pushed
the
split-rules
branch
from
6104e29 to
177c7f0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #1170 to minimize conflicts from other rule changes.
This splits the contents of the
rules.msgbfile into several parts which are loaded and ordered at codegen time according to auser-rules.partsfile. This is mainly for maintainability purposes.It also introduces a separate
system-rules.partswhich is a subset of all the binding rules and can be used to process the built-ins source file a bit faster.TODO: there's one remaining issue here and that re: error handling in the rules. If there's a problem in the binding rules, the error will be reported for a line number in the merged rules file.