Implement Definition::references()
#1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we cannot traverse the stack graph in reverse order, we resolve all references and build the reverse mapping.
🦋 Changeset detectedLatest commit: 66288a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
OmarTawfik
reviewed
Feb 7, 2025
crates/codegen/runtime/cargo/wasm/src/runtime/interface/bindings.wit.jinja2
Show resolved
Hide resolved
OmarTawfik
reviewed
Feb 7, 2025
OmarTawfik
reviewed
Feb 7, 2025
OmarTawfik
approved these changes
Feb 7, 2025
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/slang@0.20.0 ### Minor Changes - [#1203](#1203) [`a5c3b1a`](a5c3b1a) Thanks [@ggiraldez](https://github.com/ggiraldez)! - add separate contexts (ie. binding scopes) for Solidity and Yul built-ins - [#1257](#1257) [`9f5d8f0`](9f5d8f0) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - export `assertUserFileLocation()` and `assertBuiltInLocation()` utilities from the `bindings` module - [#1243](#1243) [`99d182f`](99d182f) Thanks [@ggiraldez](https://github.com/ggiraldez)! - add `definition.references()` API to find all references that resolve to a definition. - [#1205](#1205) [`103b331`](103b331) Thanks [@mjoerussell](https://github.com/mjoerussell)! - Make `Edge::label` a required field instead of being optional. - [#1257](#1257) [`9f5d8f0`](9f5d8f0) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - update user guides with new binding graph and compilation APIs - [#1257](#1257) [`9f5d8f0`](9f5d8f0) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - export `assertNonterminalNode()` and `assertTerminalNode()` utilities from the `cst` module ### Patch Changes - [#1246](#1246) [`aea2dd0`](aea2dd0) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - unreserve `jump` and `jumpi` yul keywords between `0.6.0` and `0.8.0` - [#1203](#1203) [`a5c3b1a`](a5c3b1a) Thanks [@ggiraldez](https://github.com/ggiraldez)! - enable `address payable` from 0.5.0 and remove `transfer` built-in from non-payable `address`es - [#1246](#1246) [`aea2dd0`](aea2dd0) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - make sure assembly flags are only enabled starting from `0.8.13` - [#1246](#1246) [`aea2dd0`](aea2dd0) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - enable yul's `true` and `false` keywords starting from `0.6.2` - [#1246](#1246) [`aea2dd0`](aea2dd0) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - make sure `super` and `this` keywords are unreserved before `0.8.0`. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1216
Implements
Definition::references()in bindings API by eagerly resolving all remaining unresolved references and then building a reverse mapping from definitions to references.