add semantic validation for grammar #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarTawfik
commented
Jan 13, 2023
AntonyBlakey
approved these changes
Jan 14, 2023
OmarTawfik
force-pushed
the
OmarTawfik/remove-token-sub-exp-names
branch
from
5f02a5e
to
d59bd8f
Compare
OmarTawfik
force-pushed
the
OmarTawfik/add-semantic-validation
branch
from
c25583c
to
5696e71
Compare
OmarTawfik
force-pushed
the
OmarTawfik/remove-token-sub-exp-names
branch
from
d59bd8f
to
3c0caff
Compare
Base automatically changed from
OmarTawfik/remove-token-sub-exp-names
to
main
January 18, 2023 00:54
OmarTawfik
force-pushed
the
OmarTawfik/add-semantic-validation
branch
from
5696e71
to
4b6e1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the semantic validation suite, and implements all the existing checks.
Will follow up with additional PRs for more rules.