fix unicode string parsing #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonyBlakey
approved these changes
Apr 27, 2023
sorted primary expressions to attempt sub-expressions with unique prefixes first, then literals, then identifiers at last. This prevents cases where parser recognizes an identifier at the start of `unicode""` literals.
OmarTawfik
force-pushed
the
OmarTawfik/fix-unicode-parsing
branch
from
caea93e
to
4fd5867
Compare
OmarTawfik
added a commit
that referenced
this pull request
May 4, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/slang@0.2.0 ### Minor Changes - [#435](#435) [`2a5b193`](2a5b193) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support user defined operators ### Patch Changes - [#416](#416) [`fb977a5`](fb977a5) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix primary expressions parser order - [#434](#434) [`beb3708`](beb3708) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix UnicodeStringLiteral versioning - [#430](#430) [`8b7492e`](8b7492e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - update READMEs with links to packages and user guides. - [#425](#425) [`9b49b3d`](9b49b3d) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add user guides to rust crate and npm packages. - [#432](#432) [`1d1a8bb`](1d1a8bb) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix FunctionCallOptions versioning ## changelog@0.2.0 ### Minor Changes - [#435](#435) [`2a5b193`](2a5b193) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - support user defined operators ### Patch Changes - [#416](#416) [`fb977a5`](fb977a5) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix primary expressions parser order - [#434](#434) [`beb3708`](beb3708) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix UnicodeStringLiteral versioning - [#430](#430) [`8b7492e`](8b7492e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - update READMEs with links to packages and user guides. - [#425](#425) [`9b49b3d`](9b49b3d) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add user guides to rust crate and npm packages. - [#432](#432) [`1d1a8bb`](1d1a8bb) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix FunctionCallOptions versioning --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: OmarTawfik <15987992+OmarTawfik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorted primary expressions to attempt sub-expressions with unique prefixes first, then literals, then identifiers at last. This prevents cases where parser recognizes an identifier at the start of
unicode""literals.