Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to rust 1.65.0 #452

Merged
merged 1 commit into from
May 10, 2023
Merged

upgrade to rust 1.65.0 #452

merged 1 commit into from
May 10, 2023

Conversation

OmarTawfik
Copy link
Collaborator

@OmarTawfik OmarTawfik commented May 9, 2023 •
edited
Loading

Needed to use cargo-xwin to compile NAPI binaries on windows.

@OmarTawfik
upgrade to rust 1.65.0
8ee4a9a 
Needed to use `cargo-xwin` to compile NAPI binaries
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

⚠️ No Changeset found

Latest commit: 8ee4a9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review May 10, 2023 02:01
@OmarTawfik OmarTawfik requested a review from a team as a code owner May 10, 2023 02:01
@OmarTawfik OmarTawfik enabled auto-merge May 10, 2023 02:01
@OmarTawfik OmarTawfik added this pull request to the merge queue May 10, 2023
Merged via the queue into NomicFoundation:main with commit 2f2b88f May 10, 2023
@OmarTawfik OmarTawfik deleted the upgrade-rust branch May 10, 2023 02:15
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this pull request May 10, 2023
@OmarTawfik
upgrade rust-src to 1.65.0
8a6ce10 
Missed doing that in NomicFoundation#452
@OmarTawfik OmarTawfik mentioned this pull request May 10, 2023
Merged
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this pull request May 10, 2023
@OmarTawfik
upgrade rust-src to 1.65.0
50a56e8 
Missed doing that in NomicFoundation#452
OmarTawfik added a commit that referenced this pull request May 10, 2023
@OmarTawfik
upgrade rust-src to 1.65.0 (#454)
85dec01 
Missed doing that in #452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonyBlakey AntonyBlakey AntonyBlakey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @AntonyBlakey