Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn OperatorDefinition into ParserRefs #477

Merged
merged 1 commit into from
May 24, 2023

Conversation

OmarTawfik
Copy link
Collaborator

Allows us to:

note: some of the additional nodes (like ConditionalOperator) will be inlined in #323

closes #374

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

🦋 Changeset detected

Latest commit: 1f7df16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changelog Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OmarTawfik OmarTawfik force-pushed the OmarTawfik/operators-parser-ref branch from e386d9c to 4866dc8 Compare May 23, 2023 05:03
@OmarTawfik OmarTawfik linked an issue May 23, 2023 that may be closed by this pull request
@OmarTawfik OmarTawfik marked this pull request as ready for review May 23, 2023 05:24
@OmarTawfik OmarTawfik requested a review from a team as a code owner May 23, 2023 05:24
Base automatically changed from OmarTawfik/rename-grammar-to-schema to main May 24, 2023 12:21
Allows us to:

- de-duplicate large operators across different versions
- add names to operators, doing in #353

note: some of the additional nodes (like `ConditionalOperator`) will be inlined in #323

closes #374
@OmarTawfik OmarTawfik force-pushed the OmarTawfik/operators-parser-ref branch from 4866dc8 to 1f7df16 Compare May 24, 2023 12:48
@OmarTawfik OmarTawfik enabled auto-merge May 24, 2023 12:50
@OmarTawfik OmarTawfik added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 13c85a2 May 24, 2023
@OmarTawfik OmarTawfik deleted the OmarTawfik/operators-parser-ref branch May 24, 2023 13:05
@github-actions github-actions bot mentioned this pull request May 24, 2023
OmarTawfik pushed a commit that referenced this pull request May 24, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/slang@0.5.0

### Minor Changes

- [#475](#475)
[`0cdfe86`](0cdfe86)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - match TypeScript
and Rust API namespaces

- [#477](#477)
[`13c85a2`](13c85a2)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - move expression
operators into separate nodes

- [#481](#481)
[`0269f2b`](0269f2b)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix grammar
versions of individual keywords

- [#473](#473)
[`11d8cb0`](11d8cb0)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust
1.69.0

## changelog@0.5.0

### Minor Changes

- [#475](#475)
[`0cdfe86`](0cdfe86)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - match TypeScript
and Rust API namespaces

- [#477](#477)
[`13c85a2`](13c85a2)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - move expression
operators into separate nodes

- [#481](#481)
[`0269f2b`](0269f2b)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix grammar
versions of individual keywords

- [#473](#473)
[`11d8cb0`](11d8cb0)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - upgrade to rust
1.69.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move each OperatorDefinition to its own Production
2 participants