Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript nodes should send a TextIndex object instead of a [number,number,number] tuple #513

Merged

Conversation

AntonyBlakey
Copy link
Contributor

Fixes #509

@AntonyBlakey AntonyBlakey requested a review from a team as a code owner July 6, 2023 11:41
@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

🦋 Changeset detected

Latest commit: a9ec992

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changelog Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AntonyBlakey AntonyBlakey self-assigned this Jul 6, 2023
@AntonyBlakey AntonyBlakey added this pull request to the merge queue Jul 6, 2023
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one concern about exporting the new types.

@OmarTawfik OmarTawfik removed this pull request from the merge queue due to a manual request Jul 6, 2023
@AntonyBlakey AntonyBlakey added this pull request to the merge queue Jul 11, 2023
Merged via the queue into NomicFoundation:main with commit 7e01250 Jul 11, 2023
@AntonyBlakey AntonyBlakey deleted the AntonyBlakey/issue509 branch July 11, 2023 12:10
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 11, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/slang@0.8.0

### Minor Changes

- [#513](#513)
[`7e01250`](7e01250)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Typescript
API now has TextIndex and TextRange types that are returned from the
appropriate methods rather than tuples.

### Patch Changes

- [#527](#527)
[`7ccca87`](7ccca87)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Fix pratt
parser behavior in the face of error correction

## changelog@0.8.0

### Minor Changes

- [#513](#513)
[`7e01250`](7e01250)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Typescript
API now has TextIndex and TextRange types that are returned from the
appropriate methods rather than tuples.

### Patch Changes

- [#527](#527)
[`7ccca87`](7ccca87)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Fix pratt
parser behavior in the face of error correction

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript nodes should send a TextIndex object instead of a [number,number,number] tuple
2 participants