Make ESM named imports work in Node #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing slang from a native ESM module is pretty cumbersome in Node right now. Here's an example of an error you may get if you try to use a normal named import:
This PR changes how we export things in JavaScript so that named imports from ESM modules work in Node.js.
The difference is really subtle and may be hard to understand at first glance, so here's an explanation:
default
export, as that doesn't exist in CJS.module.exports
as adefault
exports, hoping that it was the original intention of the author. That leads to named imports from ESM not working if you reassign it.module.exports
and just add properties to it, those are treated as named exports.