Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyword versions #599

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Sep 21, 2023

Non-controversial bits separated from #598.

This updates versions for the revert keyword (and the associated statement, introduced in 0.8.4) and the global (introduced in 0.8.13 for the using directive) contextual keywords in both the new DSL and our old YAML spec.

The statement was introduced alongside the `revert` contextual keyword,
see ethereum/solidity#11037.
…8.13

See ethereum/solidity#12288

It's impossible to specify a newly introduced keyword optionally in the
YML spec directly or even as an additional inline parser (`null`
definitions are treated as an undefined parser and error out), so this
adds versioning to the UsingDirective to add the new `global` contextual
keyword.
@Xanewok Xanewok requested a review from a team as a code owner September 21, 2023 13:55
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

🦋 Changeset detected

Latest commit: 6609da0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/slang Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you.
Left one suggestion.

Co-authored-by: Omar Tawfik <15987992+OmarTawfik@users.noreply.github.com>
@OmarTawfik OmarTawfik added this pull request to the merge queue Sep 22, 2023
Merged via the queue into NomicFoundation:main with commit 4bbad48 Sep 22, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Sep 22, 2023
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/slang@0.10.0

### Minor Changes

- [#595](#595)
[`1a258c4`](1a258c4)
Thanks [@Xanewok](https://github.com/Xanewok)! - Attempt error recovery
when parsing incomplete lists

- [#564](#564)
[`e326a06`](e326a06)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Parsing
operators with missing operands should no longer panic

- [#564](#564)
[`e326a06`](e326a06)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Inline parse
rules are no longer exposed to the API.

- [#564](#564)
[`e326a06`](e326a06)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Scanners are
no longer available as methods - use next_token instead

- [#564](#564)
[`e326a06`](e326a06)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Scanners are
now grouped into contexts to deal with contextual scanning

### Patch Changes

- [#601](#601)
[`cbd2a79`](cbd2a79)
Thanks [@Xanewok](https://github.com/Xanewok)! - Attempt parser error
recovery between bracket delimiters

- [#599](#599)
[`4bbad48`](4bbad48)
Thanks [@Xanewok](https://github.com/Xanewok)! - Use correct versions
for the `revert` and `global` keywords

- [#561](#561)
[`cb6a138`](cb6a138)
Thanks [@Xanewok](https://github.com/Xanewok)! - Add preliminary
documentation for the `solidity_language` Rust package

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants