Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement (contextual) keywords and use their versioning from v2 #723

Merged
merged 39 commits into from
Jan 8, 2024
Merged

Implement (contextual) keywords and use their versioning from v2 #723

merged 39 commits into from
Jan 8, 2024

Commits on Dec 23, 2023

  1. cleanup: Use BTreeMap for CodeGenerator::{scanner,parser}_functions

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    e2a7cc5 View commit details
    Browse the repository at this point in the history

  2. cleanup: Use BTreeMap for CodeGenerator::scanner_contexts

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    af43e8f View commit details
    Browse the repository at this point in the history

  3. cleanup: Mark top_level_scanner_names as unused in templates

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    be32592 View commit details
    Browse the repository at this point in the history

  4. cleanup: Hoist the Identifier hack in PG trie code

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    391c596 View commit details
    Browse the repository at this point in the history

  5. WIP: Add a comment

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    cd84e1a View commit details
    Browse the repository at this point in the history

  6. refactor: Clean up a bit Trie code

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    6c15e5d View commit details
    Browse the repository at this point in the history

  7. wtf?

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    9c048ac View commit details
    Browse the repository at this point in the history

  8. cleanup: Introduce a helper CodeGenerator::current_context fn

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    f3b520e View commit details
    Browse the repository at this point in the history

  9. Deduplicate longest_match in Lexer::next_token

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    5eeb0bd View commit details
    Browse the repository at this point in the history

  10. WIP

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    87d407a View commit details
    Browse the repository at this point in the history

  11. WIP2

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    82d9ef6 View commit details
    Browse the repository at this point in the history

  12. WIP3

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    e2da887 View commit details
    Browse the repository at this point in the history

  13. WIP more

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    08b4396 View commit details
    Browse the repository at this point in the history

  14. WIP: Add some more

    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    0746345 View commit details
    Browse the repository at this point in the history

  15. Don't always rescan with underlying when trying to scan keywords 

    Also optimize a bit the kw scanner function and remove some comments.
    @Xanewok
    Xanewok committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    7b12d89 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Make sure the identifier is always scanned as a last compound scanner

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    3f80727 View commit details
    Browse the repository at this point in the history

  2. clean up some bits

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    9ff1b90 View commit details
    Browse the repository at this point in the history

  3. Speed up lexing by only attempting kw promotion if it lexes as an ide… 

    …ntifier
    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    1c82302 View commit details
    Browse the repository at this point in the history

  4. Bring back keyword lookup using trie

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    05edbe1 View commit details
    Browse the repository at this point in the history

  5. Simplify the trie

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    05f154f View commit details
    Browse the repository at this point in the history

  6. Fix compound keyword promotion and add CST tests

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    26e55fb View commit details
    Browse the repository at this point in the history

  7. cleanup: remove unnecessary now wrong_self_convention lint

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    a0dc824 View commit details
    Browse the repository at this point in the history

  8. Simplify emitted code for the compound keyword scanners

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    90d8d88 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary comment

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    d348dde View commit details
    Browse the repository at this point in the history

  10. cleanup: Remove some WIP code

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    5180f98 View commit details
    Browse the repository at this point in the history

  11. Fix a typo

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    7de6920 View commit details
    Browse the repository at this point in the history

  12. Add more comments

    @Xanewok
    Xanewok committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    e6b5c15 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Hold the scanned kw token kind in the KeywordScan enum

    @Xanewok
    Xanewok committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    8651b2e View commit details
    Browse the repository at this point in the history

  2. Don't Option-wrap keyword scan results when using a trie

    @Xanewok
    Xanewok committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    8dc56e8 View commit details
    Browse the repository at this point in the history

  3. Introduce ScannedToken to separately handle ident/kw from the scanner 

    This also removes the `scan` from the NAPI but we wanted to hide that
anyways ourselves.
    @Xanewok
    Xanewok committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    0a615ec View commit details
    Browse the repository at this point in the history

  4. Rename identifier_scanners to identifier_scanner_names

    @Xanewok
    Xanewok committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    581d611 View commit details
    Browse the repository at this point in the history

  5. Clean up a bit the resulting next_token

    @Xanewok
    Xanewok committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    317ce6f View commit details
    Browse the repository at this point in the history

  6. perf: Only attempt scanning a compound keyword if we didn't find one

    @Xanewok
    Xanewok committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    93942ac View commit details
    Browse the repository at this point in the history

  7. Add a changeset file

    @Xanewok
    Xanewok committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    bbea7fe View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Merge remote-tracking branch 'upstream/main' into keyword-idents-take-2

    @Xanewok
    Xanewok committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7b3ec72 View commit details
    Browse the repository at this point in the history

  2. Add comments about specific keyword reservation in the CST snapshots

    @Xanewok
    Xanewok committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    322f105 View commit details
    Browse the repository at this point in the history

  3. Rename identifier_scanner_names to promotable_identifier_scanners

    @Xanewok
    Xanewok committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    2336ad9 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Merge remote-tracking branch 'upstream/main' into keyword-idents-take-2

    @Xanewok
    Xanewok committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8fe0b94 View commit details
    Browse the repository at this point in the history

  2. Add more regression CST tests

    @Xanewok
    Xanewok committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4fb350e View commit details
    Browse the repository at this point in the history