Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate codegen_spec to DSL v2 #749

Merged
merged 1 commit into from
Jan 22, 2024
Merged

migrate codegen_spec to DSL v2 #749

merged 1 commit into from
Jan 22, 2024

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Jan 19, 2024 •
edited
Loading

  • Migrate the spec to DSL v2.
  • Delete the old YAML spec (v1), and its validation infra.
  • Remove the legacy problem matcher/ebnf codegen.
  • Clean up any unused deps/packages.

@OmarTawfik OmarTawfik requested a review from a team as a code owner January 19, 2024 04:22
@OmarTawfik OmarTawfik enabled auto-merge January 19, 2024 04:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3d82562

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik force-pushed the migrate-spec-to-dsl-v2 branch 2 times, most recently from d3efd6e to a28ec76 Compare January 19, 2024 17:26
@OmarTawfik OmarTawfik mentioned this pull request Jan 19, 2024
Closed
@OmarTawfik OmarTawfik linked an issue Jan 19, 2024 that may be closed by this pull request
Migrate human-readable spec to language definition v2 #637
Closed
@OmarTawfik OmarTawfik force-pushed the migrate-spec-to-dsl-v2 branch from a28ec76 to 3d82562 Compare January 19, 2024 22:37
@OmarTawfik OmarTawfik added this pull request to the merge queue Jan 21, 2024
@AntonyBlakey AntonyBlakey removed this pull request from the merge queue due to a manual request Jan 21, 2024
@AntonyBlakey AntonyBlakey added this pull request to the merge queue Jan 22, 2024
Merged via the queue into NomicFoundation:main with commit 7119e5c Jan 22, 2024
1 check passed
@OmarTawfik OmarTawfik deleted the migrate-spec-to-dsl-v2 branch January 22, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonyBlakey AntonyBlakey AntonyBlakey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate human-readable spec to language definition v2
2 participants
@OmarTawfik @AntonyBlakey