Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rustflags with [lints] #880

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Replace rustflags with [lints] #880

merged 6 commits into from
Mar 5, 2024

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Mar 4, 2024

Closes #837

@Xanewok Xanewok requested a review from a team as a code owner March 4, 2024 18:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 83d42fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

OmarTawfik
OmarTawfik reviewed Mar 4, 2024
View reviewed changes
OmarTawfik
OmarTawfik approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xanewok Xanewok added this pull request to the merge queue Mar 5, 2024
Merged via the queue into NomicFoundation:main with commit e149262 Mar 5, 2024
1 check passed
@Xanewok Xanewok deleted the clippy-lints branch March 5, 2024 10:20
@Xanewok Xanewok mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace rustflags with [lints]
2 participants
@Xanewok @OmarTawfik