Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only allow an identifier in the Yul variable declaration position #948

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix: Only allow an identifier in the Yul variable declaration position #948

merged 2 commits into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. Add a regression test first

    @Xanewok
    Xanewok committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ce5d942 View commit details
    Browse the repository at this point in the history

  2. fix: Only allow YulIdentifier in the Yul variable declaration 

    Previously, Yul identifiers could have dots in the name but that's not
the case starting from 0.7. As such, we need to disallow these forms for
the variable declaration and instead only accept the identifier, as is
done by the upstream grammar.
    @Xanewok
    Xanewok committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    25eacd8 View commit details
    Browse the repository at this point in the history